Fix gcc errors arising from latest commit (incomplete sight_map implementation)#55
Open
keyspace wants to merge 4 commits into
Open
Fix gcc errors arising from latest commit (incomplete sight_map implementation)#55keyspace wants to merge 4 commits into
keyspace wants to merge 4 commits into
Conversation
added 4 commits
January 31, 2017 13:25
…ations. Squelches gcc errors.
It seems that 8635e2e, which introduced the code, was patch-added, and is missing a hunk! Fix up for compilation, but know that things are seriously broken. Also, tried to just move `build_sight_map()` down after its `build_tile_sight_map()` helper, but for some reason, `gcc` was still complaining. So, declare in header.
Compiles now, with ~10 warnings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tried to build HEAD with
gcc (GCC) 6.3.1 20170109, got errors.It seems you quit in the middle of your work - which is OK, but it is dissuading for anyone trying to build for the first time, and not knowing to
git reset --hard HEAD~1.