Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On the HP Elite Dragonfly Chromebook (Redrix), Mic1 can capture sound but have an unusably low recording level. The tested system also selected the speaker monitor as its default source under WirePlumber 0.5.13.
Depends on WeirdTreeThing/alsa-ucm-conf-cros#2 to stop exposing the unused Mic2 channels. That UCM change should land on
standalonebefore this installer change is released, sinceinstall_ucm()fetches that branch.Install Redrix-specific microphone configuration after detecting its DMI product name:
The gain is empirical compensation validated on one Redrix; the underlying reason for its low raw capture level has not been established. It is not a firmware or topology fix. WirePlumber 0.5.14 separately fixes automatic selection of sink monitors as default sources; the priority rule also provides a board-specific ordering policy for older releases.
Validation
PYTHONDONTWRITEBYTECODE=1 python3 -m unittest discover -s tests -v: all 11 tests passed. Coverage includes board matching, version boundaries, failed/timed-out probes, repeated installation, downgrade and board-migration cleanup, and preservation of unmanaged configuration.pw-config. Matching against the captured device properties selected only Mic1, and the filter actions matched the working local configuration.sof-rt5682, PipeWire 1.6.2 and WirePlumber 0.5.13. The machine's owner confirmed successful recording with the system recorder after restoring input volume to 100% and applying the gain.git diff --checkpassed.The complete installer has not been run on a clean installation, and reboot, suspend/resume, and additional Redrix units have not been tested as part of this PR.
Version references: WirePlumber 0.5.13 filter-graph support, PipeWire 1.4.0 audioconvert filter graphs, and WirePlumber 0.5.14 default-source fix.