fix(i18n): the admin chrome was still hardcoded English (v1.0.2) - #185
Merged
Conversation
The platform ships six locales, but PUMA's shared chrome rendered its own labels as literals — My Profile, Lock Screen, Sign Out, Alerts, View all, Activity, the agent aside, the theme/skin/language switchers, the consent banner, and the cron + schedule setup screens stayed English in every locale. 'Skip to content' — an accessibility affordance — was untranslated too. 93 keys across themes/puma/languages/*/theme.php; all six locales at 133 with identical key sets. Time-ago strings became sprintf keys; the inline-JS 'User' fallback now reads a translated data-fallback attribute. DELIBERATELY still English: cPanel/Plesk control names in the cron instructions (Add New Cron Job, Common Settings, ...). The user is hunting for those exact labels on an English cPanel screen — translating them would send them after a button that doesn't exist. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The platform ships six locales — but PUMA's shared admin chrome rendered its own labels as literals, so they stayed English no matter what language you picked.
Visible examples: My Profile, Lock Screen, Sign Out, Alerts, View all, Activity, Drop files to attach, the theme/skin/language switchers, the consent banner, and the whole cron + schedule setup UI.
Skip to content— an accessibility affordance — was untranslated as well.93 keys added to
themes/puma/languages/*/theme.php. All six locales at 133 keys with identical key sets (verified as sorted key arrays, not just counts). Time-ago strings becamesprintfkeys instead of baked-in English, and the inline-JS'User'fallback now reads a translateddata-fallbackattribute.Deliberately NOT translated
The cron setup walks the user through cPanel's and Plesk's own English screens. Control names — Advanced → Cron Jobs, Add New Cron Job, Common Settings, Once Per Minute — stay verbatim in every locale, wrapped so they read as quoted UI names. Translating them would send someone hunting for a button that doesn't exist on their screen. Same rule for brands and for skin origin names (
Zephyr,Flatly).The Claude Code prompt text is translated — that's prose you type at a multilingual agent, not a control you have to find.
Suite: 2043 / 0 failures, unchanged.
Known, pre-existing, not addressed here
admin-header.phtmlandconsent-banner.phtmlstill carry inline<script>blocks, against the house no-inline-script rule. Untouched beyond thedata-fallbackswap — worth its own pass.🤖 Generated with Claude Code