fix: drop agent EID suffix on multisig OOBI by default#447
Open
kentbull wants to merge 1 commit into
Open
Conversation
372b486 to
7a0c814
Compare
This has been a constant source of confusion for years and should return the intuitive result by default, the multisig Agent OOBI with no agent EID suffix. The includeEid URL parameter allows using the old behavior, if desired.
7a0c814 to
73fbcab
Compare
This was referenced Jul 2, 2026
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #447 +/- ##
==========================================
+ Coverage 87.75% 87.86% +0.10%
==========================================
Files 26 26
Lines 5825 5877 +52
==========================================
+ Hits 5112 5164 +52
Misses 713 713 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has been a constant source of confusion for years and should return the intuitive result by default, the multisig Agent OOBI with no agent EID suffix.
The includeEid URL parameter allows using the old behavior, if desired.
SignifyTS PR: WebOfTrust/signify-ts#400
SignifyPy PR: WebOfTrust/signifypy#150