Skip to content

fix: drop agent EID suffix on multisig OOBI by default#447

Open
kentbull wants to merge 1 commit into
WebOfTrust:mainfrom
kentbull:default-drop-agent-eid-suffix-for-multisig-oobi
Open

fix: drop agent EID suffix on multisig OOBI by default#447
kentbull wants to merge 1 commit into
WebOfTrust:mainfrom
kentbull:default-drop-agent-eid-suffix-for-multisig-oobi

Conversation

@kentbull

@kentbull kentbull commented Jul 2, 2026

Copy link
Copy Markdown
Collaborator

This has been a constant source of confusion for years and should return the intuitive result by default, the multisig Agent OOBI with no agent EID suffix.

The includeEid URL parameter allows using the old behavior, if desired.

SignifyTS PR: WebOfTrust/signify-ts#400
SignifyPy PR: WebOfTrust/signifypy#150

@kentbull kentbull force-pushed the default-drop-agent-eid-suffix-for-multisig-oobi branch 2 times, most recently from 372b486 to 7a0c814 Compare July 2, 2026 18:58
This has been a constant source of confusion for years and should return the intuitive result by default, the multisig Agent OOBI with no agent EID suffix.

The includeEid URL parameter allows using the old behavior, if desired.
@codecov

codecov Bot commented Jul 2, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.55072% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 87.86%. Comparing base (8a1b9e2) to head (73fbcab).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
src/keria/app/aiding.py 95.65% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #447      +/-   ##
==========================================
+ Coverage   87.75%   87.86%   +0.10%     
==========================================
  Files          26       26              
  Lines        5825     5877      +52     
==========================================
+ Hits         5112     5164      +52     
  Misses        713      713              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant