Skip to content

fix: use exn.rp field as recipient for exchange message (#3)#396

Draft
lenkan wants to merge 3 commits into
WebOfTrust:mainfrom
lenkan:fix-exn-recipient
Draft

fix: use exn.rp field as recipient for exchange message (#3)#396
lenkan wants to merge 3 commits into
WebOfTrust:mainfrom
lenkan:fix-exn-recipient

Conversation

@lenkan

@lenkan lenkan commented Nov 3, 2025

Copy link
Copy Markdown
Collaborator

All exchange messages now have the intended recipient in the payload, so the extra body parameter is confusing and could cause issues.

This PR removes the "rec" body parameter that previously specified a list of recipients of an exn message. This list had no correlation with the rp field in the exchange message payload.

This PR also removes the ipex multisig handlers, for no other reason that they weren't used in any of the signify integration tests, so to me it was unnecessary complexity. I do not see any reason to keep this feature as we already use the "/multisig/exn" from the client.

See discussions:

@codecov

codecov Bot commented Nov 6, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 67.64706% with 22 lines in your changes missing coverage. Please review.
✅ Project coverage is 85.78%. Comparing base (8a1b9e2) to head (d8cf00e).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/keria/app/agenting.py 34.37% 21 Missing ⚠️
src/keria/peer/exchanging.py 75.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (67.64%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   87.75%   85.78%   -1.98%     
==========================================
  Files          26       26              
  Lines        5825     5649     -176     
==========================================
- Hits         5112     4846     -266     
- Misses        713      803      +90     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kentbull

kentbull commented Jul 8, 2026

Copy link
Copy Markdown
Collaborator

@lenkan will you rebase this on main? Also, is it ready for review?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants