fix: use exn.rp field as recipient for exchange message (#3)#396
Draft
lenkan wants to merge 3 commits into
Draft
fix: use exn.rp field as recipient for exchange message (#3)#396lenkan wants to merge 3 commits into
lenkan wants to merge 3 commits into
Conversation
Codecov Report❌ Patch coverage is
❌ Your patch check has failed because the patch coverage (67.64%) is below the target coverage (75.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
==========================================
- Coverage 87.75% 85.78% -1.98%
==========================================
Files 26 26
Lines 5825 5649 -176
==========================================
- Hits 5112 4846 -266
- Misses 713 803 +90 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Collaborator
|
@lenkan will you rebase this on main? Also, is it ready for review? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All exchange messages now have the intended recipient in the payload, so the extra body parameter is confusing and could cause issues.
This PR removes the "rec" body parameter that previously specified a list of recipients of an exn message. This list had no correlation with the
rpfield in the exchange message payload.This PR also removes the ipex multisig handlers, for no other reason that they weren't used in any of the signify integration tests, so to me it was unnecessary complexity. I do not see any reason to keep this feature as we already use the "/multisig/exn" from the client.
See discussions:
recpfield in POST body #270