Skip to content

Changed to non deprecated removes that should have same effect as old…#167

Open
daidoji wants to merge 1 commit into
mainfrom
move-from-map-remove-to-non-deprecated-remove
Open

Changed to non deprecated removes that should have same effect as old…#167
daidoji wants to merge 1 commit into
mainfrom
move-from-map-remove-to-non-deprecated-remove

Conversation

@daidoji

@daidoji daidoji commented Jan 31, 2024

Copy link
Copy Markdown
Collaborator

Rationale

Not really sure why these didn't show up in my old env but in my new env got deprecation warnings about map.remove being deprecated and to use swap or shift remove to be explicit about behavior.

Switched to something that seemed to fit with old code and tests still pass.

Testing

Tests remain same, no change to behavior.

For Reviewers

  • Verify version bumped in Cargo.toml

@codecov

codecov Bot commented Jan 31, 2024

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.42%. Comparing base (7cd5453) to head (70645e2).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #167   +/-   ##
=======================================
  Coverage   95.42%   95.42%           
=======================================
  Files          32       32           
  Lines        3037     3037           
=======================================
  Hits         2898     2898           
  Misses        139      139           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant