Cassandra Handler - #1662
Open
gonzalotguerrero wants to merge 11 commits into
Open
Conversation
jgaleotti
requested changes
Aug 6, 2026
| */ | ||
| private String tableSchema; | ||
|
|
||
| public CassandraFailedQuery(String keyspaceName, String tableName, String tableSchema) { |
Collaborator
There was a problem hiding this comment.
add Objects.requireNonNull for those fields that should be non-null
|
|
||
| public CqlTableReference(String keyspaceName, String tableName) { | ||
| this.keyspaceName = keyspaceName; | ||
| this.tableName = tableName; |
Collaborator
There was a problem hiding this comment.
keyspaceName and tableName can be null? Otherwise add Objects.requireNonNull()
| * a SELECT/UPDATE/DELETE) | ||
| */ | ||
| public static CqlTableReference getTableReference(CqlParser.RootContext root) { | ||
| CqlParser.CqlContext cql = root.cqls() != null ? root.cqls().cql(0) : null; |
Collaborator
There was a problem hiding this comment.
if the command was not a SELECT/UPDATE/DELETE should this throw an IllegalArgumentException?
| /* | ||
| Names of the driver methods invoked via reflection throughout this class. | ||
| */ | ||
| public static final String METHOD_EXECUTE = "execute"; |
Collaborator
There was a problem hiding this comment.
why public? shouldn't these constants be private?
| public static final String CLUSTERING_COLUMN_SUFFIX = " CLUSTERING"; | ||
|
|
||
|
|
||
| public static final String SELECT_ALL_PREFIX = "SELECT * FROM "; |
| */ | ||
| public class CqlDistanceWithMetrics { | ||
|
|
||
| public final double cqlDistance; |
Collaborator
There was a problem hiding this comment.
replace this with getters, change visibility to private
|
|
||
| public final int numberOfEvaluatedRows; | ||
|
|
||
| public CqlDistanceWithMetrics(double cqlDistance, int numberOfEvaluatedRows) { |
Collaborator
There was a problem hiding this comment.
can the arguments be null? Otherwise add Objects.requireNonNull()
| } | ||
|
|
||
| private static CqlTableReference parseTableReference(String cql) { | ||
| return CqlParserUtils.getTableReference(CqlParserUtils.parseCqlCommand(cql)); |
Collaborator
There was a problem hiding this comment.
refactor CqlParserUtils.parseCqlCommand(cql) to a variable
| private final String tableName; | ||
|
|
||
| public TableKey(String keyspaceName, String tableName) { | ||
| this.keyspaceName = keyspaceName; |
Collaborator
There was a problem hiding this comment.
can keyspaceName be null? can tableName be null? Add Objects.requireNull and Javadoc
| return CassandraSchemaTracer.resolveKeyspaceName(cqlSession, null); | ||
| } catch (RuntimeException e) { | ||
| SimpleLogger.uniqueWarn("Failed to resolve Cassandra session's default keyspace"); | ||
| return null; |
Collaborator
There was a problem hiding this comment.
why should this be failing? If it is not expected it must throw exception
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.