introducing isDependentTaint()

Author: arcuri82

core/src/main/kotlin/org/evomaster/core/search/Individual.kt

@@ -510,6 +510,7 @@ abstract class Individual(
 
         val taintableGenes = all.filterIsInstance<TaintableGene>()
             .filter { TaintInputName.isTaintInput(it.getPossiblyTaintedValue()) }
+            .filter { !it.isDependentTaint() }
 
         val duplicates = CollectionUtils.duplicates(taintableGenes.map { it.getPossiblyTaintedValue() })
 
@@ -523,9 +524,7 @@ abstract class Individual(
            val same = taintableGenes.filter { it.getPossiblyTaintedValue() == d.key }.map { it as Gene }
            if(same.any{ x ->
                same.any { y ->
-                      y !=x
-                   && !y.hasAnyBindingRelationship(x)
-                   && !y.areAncestorDescendantRelated(x)
+                      y !=x && !y.hasAnyBindingRelationship(x)
                }
            }){
                errors.add("Taint id ${d.key} has duplicate genes that are not related}")

core/src/main/kotlin/org/evomaster/core/search/gene/interfaces/TaintableGene.kt

@@ -21,8 +21,13 @@ interface TaintableGene {
      */
     fun forceNewTaintId()
 
+    /**
+     * Specify that this taint value is bound to another tainted value
+     */
+    fun isDependentTaint() = false
+
     /**
      * If the individual has any dormant gene, do evolve, ie., resolve the taint
      */
     fun evolve()
-}
+}

core/src/main/kotlin/org/evomaster/core/search/gene/string/StringGene.kt

@@ -5,6 +5,7 @@ import org.evomaster.client.java.instrumentation.shared.RegexSharedUtils
 import org.evomaster.client.java.instrumentation.shared.StringSpecialization
 import org.evomaster.client.java.instrumentation.shared.StringSpecializationInfo
 import org.evomaster.client.java.instrumentation.shared.TaintInputName
+import org.evomaster.client.java.instrumentation.shared.TaintInputName.TAINTED_MAP_EM_LABEL_IDENTIFIER
 import org.evomaster.core.EMConfig
 import org.evomaster.core.Lazy
 import org.evomaster.core.StaticCounter
@@ -1065,12 +1066,18 @@ class StringGene(
     }
 
     override fun forceNewTaintId() {
-        if(TaintInputName.isTaintInput(value) && verifyIfNewTaintWouldBeFine()){
+        if(!isDependentTaint()
+            && TaintInputName.isTaintInput(value)
+            && verifyIfNewTaintWouldBeFine()){
             forceTaintedValue()
             //note: selectedSpecialization is NOT modified here
         }
     }
 
+    override fun isDependentTaint(): Boolean{
+        return name == TAINTED_MAP_EM_LABEL_IDENTIFIER
+    }
+
     override fun evolve() {
         //TODO need refactoring
     }

core/src/main/kotlin/org/evomaster/core/taint/TaintAnalysis.kt

@@ -464,13 +464,10 @@ object TaintAnalysis {
              */
             //assert(false) // crash in tests, but not production
         } else {
-            if (genes.size > 1
+            val toModify = genes.filter { !it.isDependentTaint() }
+            if (toModify.size > 1
                     && TaintInputName.isTaintInput(taintedInput)
-                    && genes.none { x -> genes.any { y ->
-                        y.hasAnyBindingRelationship(x)
-                        || y.areAncestorDescendantRelated(x)
-                    }
-                    }
+                    && toModify.none { x -> toModify.any { y -> y.hasAnyBindingRelationship(x) } }
             ) {
                 //shouldn't really be a problem... but let keep track for it, for now at least.
                 // note, cannot really guarantee that a taint from regex is unique, as regex could generate
@@ -479,9 +476,9 @@ object TaintAnalysis {
                 log.warn("More than 2 genes have the taint '{}'", taintedInput)
                 assert(false)
             }
-            genes
-                .filter { it.name != TaintInputName.TAINTED_MAP_EM_LABEL_IDENTIFIER /* should never be modified */ }
-                .forEach { it.addSpecializations(taintedInput, specializations, randomness, enableConstraintHandling = enableConstraintHandling) }
+            toModify.forEach {
+                it.addSpecializations(taintedInput, specializations, randomness, enableConstraintHandling = enableConstraintHandling)
+            }
         }
     }
 }