working on nested taint ids issue

Author: arcuri82

core/src/main/kotlin/org/evomaster/core/search/Individual.kt

@@ -521,8 +521,14 @@ abstract class Individual(
 
         duplicates.entries.forEach { d ->
            val same = taintableGenes.filter { it.getPossiblyTaintedValue() == d.key }.map { it as Gene }
-           if(same.any{ x -> same.any { y -> y !=x && !y.hasAnyBindingRelationship(x)}}){
-               errors.add("Taint id ${d.key} has duplicate genes that are not bound}")
+           if(same.any{ x ->
+               same.any { y ->
+                      y !=x
+                   && !y.hasAnyBindingRelationship(x)
+                   && !y.areAncestorDescendantRelated(x)
+               }
+           }){
+               errors.add("Taint id ${d.key} has duplicate genes that are not related}")
            }
         }
         return errors

core/src/main/kotlin/org/evomaster/core/search/StructuralElement.kt

@@ -475,4 +475,21 @@ abstract class StructuralElement (
     fun <T:StructuralElement> getFirstParent(klass: Class<T>) : T? {
         return getFirstParent { klass.isAssignableFrom(it.javaClass) } as T?
     }
+
+    /**
+     * Check if there is any ancestor-descendant relationship between
+     * [this] and [other], or vice-versa
+     */
+    fun areAncestorDescendantRelated(other: StructuralElement) : Boolean{
+        if(this == other){
+            return false
+        }
+        if(this.existAnyParent { it == other }){
+            return true
+        }
+        if(other.existAnyParent { it == this }){
+            return true
+        }
+        return false
+    }
 }

core/src/main/kotlin/org/evomaster/core/taint/TaintAnalysis.kt

@@ -466,7 +466,11 @@ object TaintAnalysis {
         } else {
             if (genes.size > 1
                     && TaintInputName.isTaintInput(taintedInput)
-                    && genes.none { x -> genes.any { y -> y.hasAnyBindingRelationship(x) } }
+                    && genes.none { x -> genes.any { y ->
+                        y.hasAnyBindingRelationship(x)
+                        || y.areAncestorDescendantRelated(x)
+                    }
+                    }
             ) {
                 //shouldn't really be a problem... but let keep track for it, for now at least.
                 // note, cannot really guarantee that a taint from regex is unique, as regex could generate
@@ -480,4 +484,4 @@ object TaintAnalysis {
                 .forEach { it.addSpecializations(taintedInput, specializations, randomness, enableConstraintHandling = enableConstraintHandling) }
         }
     }
-}
+}