fix: installed wallet login with wallet-discovery disabled#2531
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
lionellbriones
approved these changes
Jul 22, 2026
lionellbriones
left a comment
Contributor
There was a problem hiding this comment.
works.. tested as well
chaitanyapotti
approved these changes
Jul 22, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira Link
Description
Fixes two bugs in the Connect Wallet screen when
modalConfig.hideWalletDiscoveryis enabled (showWalletDiscovery: falsein the demo).When wallet discovery is off, the modal skips the wallet registry and shows only installed/configured external connectors. With
externalWalletOnlyenabled, users land directly on this screen (social login is hidden), so both issues are especially visible there.1. External wallet search did not filter results
filteredButtonsonly applied the search query whenwalletDiscoverySupportedwas true. With discovery disabled, it returned allinstalledWalletButtonsunchanged, so typing in the search input had no effect.Fix: Extract a shared
matchesSearchhelper and apply it toinstalledWalletButtonsas well. Search matches both connectornameanddisplayName(e.g. "MetaMask" matchesmetamask).2. Installed wallet login did not trigger (e.g. MetaMask popup)
installedWalletButtonswas built withoutisInstalled: true.handleWalletClickuses that flag to decide whether to callhandleExternalWalletClick(which opens the wallet connector). Without it, clicks were routed to the wallet-discovery path (QR code / install links) instead of connecting.Fix: Set
isInstalled: trueon installed wallet buttons, along withiconandchainNamespacesfrom the connector config, matching the shape used elsewhere (e.g.installedConnectorButtonsinRoot.tsx).How has this been tested?
Manual testing in
demo/vue-app-new:Screenshots (if appropriate)
N/A
Types of changes
Checklist
Note
Low Risk
Scoped UI fix in Connect Wallet list/search for the no–wallet-discovery path; no auth or backend changes.
Overview
Fixes the Connect Wallet flow when wallet discovery is off (empty or missing wallet registry), so users can search and successfully connect with installed/injected connectors only.
Installed wallet list entries now carry the same metadata the click handler expects:
isInstalled: true, connector icon, and chainNamespaces fromexternalWalletsConfig. Without these, installed wallets could render but fail or mis-route on selection (e.g. chain picker / connector connect).Search now filters the installed-only wallet list via a shared
matchesSearchhelper (matches connector name and displayName), not only the discovery/registry path.Lockfile bumps
@web3auth/modal/@web3auth/no-modal11.2.0 → 11.3.0 in the demo app.Reviewed by Cursor Bugbot for commit ad5fcb3. Bugbot is set up for automated code reviews on this repo. Configure here.