Skip to content

fix: installed wallet login with wallet-discovery disabled#2531

Merged
chaitanyapotti merged 2 commits into
masterfrom
fix/ext-login-modal
Jul 22, 2026
Merged

fix: installed wallet login with wallet-discovery disabled#2531
chaitanyapotti merged 2 commits into
masterfrom
fix/ext-login-modal

Conversation

@lwin-kyaw

@lwin-kyaw lwin-kyaw commented Jul 22, 2026

Copy link
Copy Markdown
Contributor

Jira Link

Description

Fixes two bugs in the Connect Wallet screen when modalConfig.hideWalletDiscovery is enabled (showWalletDiscovery: false in the demo).

When wallet discovery is off, the modal skips the wallet registry and shows only installed/configured external connectors. With externalWalletOnly enabled, users land directly on this screen (social login is hidden), so both issues are especially visible there.

1. External wallet search did not filter results

filteredButtons only applied the search query when walletDiscoverySupported was true. With discovery disabled, it returned all installedWalletButtons unchanged, so typing in the search input had no effect.

Fix: Extract a shared matchesSearch helper and apply it to installedWalletButtons as well. Search matches both connector name and displayName (e.g. "MetaMask" matches metamask).

2. Installed wallet login did not trigger (e.g. MetaMask popup)

installedWalletButtons was built without isInstalled: true. handleWalletClick uses that flag to decide whether to call handleExternalWalletClick (which opens the wallet connector). Without it, clicks were routed to the wallet-discovery path (QR code / install links) instead of connecting.

Fix: Set isInstalled: true on installed wallet buttons, along with icon and chainNamespaces from the connector config, matching the shape used elsewhere (e.g. installedConnectorButtons in Root.tsx).

How has this been tested?

Manual testing in demo/vue-app-new:

  1. Disable Show Wallet Discovery
  2. Enable External Wallet Only (Hide Social Login)
  3. Open the login modal
  4. Search: Type a wallet name in the search input — list filters correctly
  5. Login: Click MetaMask — extension confirmation popup appears and connection completes

Screenshots (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist

  • My code follows the code style of this project. (run lint)
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Note

Low Risk
Scoped UI fix in Connect Wallet list/search for the no–wallet-discovery path; no auth or backend changes.

Overview
Fixes the Connect Wallet flow when wallet discovery is off (empty or missing wallet registry), so users can search and successfully connect with installed/injected connectors only.

Installed wallet list entries now carry the same metadata the click handler expects: isInstalled: true, connector icon, and chainNamespaces from externalWalletsConfig. Without these, installed wallets could render but fail or mis-route on selection (e.g. chain picker / connector connect).

Search now filters the installed-only wallet list via a shared matchesSearch helper (matches connector name and displayName), not only the discovery/registry path.

Lockfile bumps @web3auth/modal / @web3auth/no-modal 11.2.0 → 11.3.0 in the demo app.

Reviewed by Cursor Bugbot for commit ad5fcb3. Bugbot is set up for automated code reviews on this repo. Configure here.

@lwin-kyaw
lwin-kyaw requested review from a team as code owners July 22, 2026 08:30
@vercel

vercel Bot commented Jul 22, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
web3auth-web Ready Ready Preview, Comment Jul 22, 2026 8:30am

Request Review

@lionellbriones lionellbriones left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works.. tested as well

@chaitanyapotti
chaitanyapotti merged commit 0bb2b31 into master Jul 22, 2026
7 checks passed
@chaitanyapotti
chaitanyapotti deleted the fix/ext-login-modal branch July 22, 2026 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants