refresh command-output icons#486
Merged
Merged
Conversation
Reload icons specified by a filesystem path after command execution completes. This allows dynamic icons such as album art to update on the widget refresh interval while preserving the original behavior for static theme icons.
Collaborator
|
I'm labeling this as a bugfix as I think it's reasonable to assume this would work. Happy to merge once you pass uncrust ;) |
Contributor
Author
|
ok ill update the wiki to summarize the changes once merged. thanks |
Collaborator
|
Thank you :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for dynamic command-output icons.
When the icon is specified as a filesystem path, it is reloaded after each command execution on the configured refresh interval. This allows icons for such such things as album art or weather icons to update automatically.
Icons specified by name (theme icons) continue to use the original static behavior and are not reloaded.