fix(tide): detect git/composer cross-platform in ScaffoldCommand#2
Merged
Conversation
The previous \command -v X 2>/dev/null\ pattern is Unix-only; on Windows, cmd.exe tries to run a literal \command\ binary and the \/dev/null\ redirect produces 'The system cannot find the path specified.', so \ ide new\ falsely reported git as missing. Add a \Command::findExecutable()\ helper that uses \where\ on Windows and \command -v\ elsewhere, then route ScaffoldCommand through it. Covered by a new FindExecutableTest.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
\ ide new\ falsely reported \git is not installed or not on PATH.\ on Windows because the lookup used the Unix-only \command -v X 2>/dev/null\ shell snippet. cmd.exe has no \command\ builtin and treats /dev/null\ as a literal path, so the command returned empty even when git was on PATH.
Changes
Verification (local, Windows + PHP 8.4.21)