Repository navigation
parity-surface: on the frozen 1.x line, re-cite closed allowlist issues to #511 - #669
Merged
Merged
Conversation
…511 21 allowlist entries on main cited closed issues (#500: 19, #499: 1, #487: 1), so the report-only parity-surface job's --check-issues step was red. Those issues closed because their fixes landed on v2 (#500 by #608), not on 1.x: main's surface is frozen, and every interface change goes to the 2.x line, which #511 (open) tracks. By the allowlist's own rule an entry's `issue` is the open issue its fix waits on, so each of the 21 now cites #511. No entry, name or reason changes. v2's allowlist cites only #511 already. Fixes #666 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On
main, the report-onlyparity-surfacejob's step "allowlist issues — no entry cites a closed issue" (scripts/parity-surface.py --check-issues) was red. 21 entries inscripts/parity-surface-allow.jsoncited closed issues: #500 (19), #499 (1) and #487 (1). #666 counted only the #500 ones.Those issues closed because their fixes landed on the 2.x line (
v2; #500 by #608), not on 1.x.mainis the frozen 1.x line: its public surface doesn't change, and every interface change goes to 2.x, which #511 (open) tracks. By the allow-list's own rule, an entry'sissueis the open issue its fix waits on, so each of the 21 entries now cites #511 instead.issueedits.v2's allow-list already cites only ABI v2 and the 2.0.0-dev channel: every interface change goes here (v1 is frozen) #511 (open), so it needs no change.Fixes #666.
Test plan
scripts/parity-surface.py --check-issues: ok, the only cited issue is ABI v2 and the 2.0.0-dev channel: every interface change goes here (v1 is frozen) #511, which is open.scripts/parity-surface.py --selftestandscripts/lint-public.sh.🤖 Generated with Claude Code