Repository navigation
spec (v2): a\b reads as two bytes; drop the column_defaults value-encoding hedge - #668
Merged
Merged
Conversation
chs_filter_create's description said the query parameter `a\b` reads as `a`, the byte 0x08 and `b`. ClickHouse's escaped-text reader consumes the `b` as the escape's letter, so it reads as two bytes, `a` and 0x08; the library already matches the server (#663). The column_defaults rule's "value is read in the body format's own field encoding" no longer carries "(the implementing build confirms)": build 20261021.025722 was measured downstream reading CSV quoting, TSV escapes and a JSON string or number for a number type, with a value that doesn't read refused before any body byte (worked examples in docs/guides/batches.md). Prose only: regenerated with gen.py --major 2 --write; the header diff is comment lines only; the ABI v2 fingerprint is unchanged, sha256:d53239933966...41c2, measured before and after. Fixes #663 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two prose corrections in the ABI v2 description, regenerated into the header comment and
docs/reference/abi-v2.md.chs_filter_create(v2 spec: chs_filter_create's text saysa\breads as three bytes; it reads as two (a, 0x08) #663): the query parametera\bnow reads as two bytes,aand 0x08, instead ofa, 0x08 andb. ClickHouse's escaped-text reader consumes thebas the escape's letter. The library already matches the server; only the text was wrong.column_defaults: the sentence saying avalueis read in the body format's own field encoding loses its "(the implementing build confirms)" hedge. Build20261021.025722was measured by a downstream user doing exactly that: CSV quoting, TSV escapes, and a JSON string or number for a number type. A value that doesn't read is refused before any body byte. The worked examples are indocs/guides/batches.md. The paragraph's other two hedges (a Nullablenull, an EPHEMERAL column) weren't covered by that measurement, so they stay.Prose only.
sha256:d53239933966e15a3c363e631a94fbba1231d84c4300337115d3ae5377bb41c2both before and after (gen.py --major 2 --fingerprint).include/v2/chtypes.hdiff is comment lines only.Fixes #663.
Test plan
gen.py --major 2 --writethen--check(0), and the fingerprint before and after (equal).check-no-hand-decls.py --scope all,lint-cited-paths.sh,lint-spelling.sh,markdownlint-cli2@0.18.1anddprint@0.57.4 checkon the changed .md, andlint-public.sh.🤖 Generated with Claude Code