Repository navigation
docs (v2): the Spans change compiles silently in Go; how a column_defaults value is read - #667
Merged
Merged
Conversation
BatchResult.Spans became []*Span (Python: Span | None, TS: Span | null), nil for a row the export did not carry. In Go, code written for []Span that reads r.Spans[i].Off still compiles and panics at run time on a nil entry; Python and TS fail the same way at run time; Rust's Option makes the compiler catch it. The four CHANGELOG bullets and the bindings-v1.md row now say so. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The value is read in the body format's own field encoding, by the reader that reads that column's field: CSV quoting, TSV escapes, a JSON string or number. Measured by a downstream user on build 20261021.025722 (darwin-arm64). A value that does not read is refused at the call, before any body byte. Guide subsection plus one CHANGELOG bullet per binding; spec/abi-v2/ is untouched and the ABI v2 fingerprint is unchanged (d53239933966...41c2, measured before and after). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spec batch 2 (#655) made each binding's
BatchResult.spanshold one entry per row, with an empty entry for a row the export did not carry: Go[]*Span, PythonSpan | None, TSSpan | null, RustOption<Span>.A downstream user found that in Go the change compiles silently. Code written for
[]Spanthat readsr.Spans[i].Offstill builds, because Go dereferences the pointer, and then panics at run time on a nil entry. Python and TS fail the same way at run time; Rust'sOptionmakes the compiler catch it.spansrow indocs/reference/bindings-v1.mdsays the same (dprint realigned that table).Also: how a
column_defaultsvalue is read (docs/guides/batches.md, plus one CHANGELOG bullet per binding). The value is read in the body format's own field encoding, by the reader that reads that column's field. Measured by a downstream user on build20261021.025722(darwin-arm64):"a,""b"is read, and an unquoteda,bis refused with error 27;a\tbis read, and a raw tab is refused with error 27;"42"and42both read intoUInt32;spec/abi-v2/docs.mdalready states the rule; it isn't edited here.Docs only, with no code change. Nothing under
spec/abi-v2/orinclude/v2/changes. The ABI v2 fingerprint issha256:d53239933966…41c2both before and after this change (measured withgen.py --major 2 --fingerprint).Test plan
markdownlint-cli2@0.18.1,dprint@0.57.4 check,lint-spelling.sh,parity-surface.py --selftestandlint-public.sh.🤖 Generated with Claude Code