go 1.0.1: a consumer's go mod tidy works again (closes #454) - #455
Merged
Merged
Conversation
go/v1.0.0 kept five retained 0.x files behind `//go:build chtypes_v0_retired`. `go mod tidy` considers every build tag except `ignore`, so in any module that depends on this one it resolved their imports, including go/internal/testhook, which 1.0.0 no longer ships, failed, and left the consumer's go.sum incomplete (measured against the published module). They now carry `//go:build ignore`: the files stay, still protected, and their deletion stays held (#431). Nothing in the built package changes. The release verification's Go consumer module now runs `go mod tidy` with no -e and no masking, in every dry run and after every publish, so this class fails before a tag. Go's bindingVersion is 1.0.1, and go/CHANGELOG.md has the entry. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_012NdkF6p8Q3qkdxKCgbdjgb
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
go 1.0.1: a consumer's
go mod tidyworks again. Closes #454.The defect (
measuredagainst the published go/v1.0.0 from the Go proxy):go mod tidyfails, because the module "does not contain package github.com/wave-rf/chtypes/go/internal/testhook".go.sumtherefore stays incomplete, and a fresh consumer'sgo buildfails too.The cause:
go/chtypes/sat behind//go:build chtypes_v0_retired.go mod tidyconsiders every build tag exceptignore, so it resolved their imports.The fix:
//go:build ignore. The files stay in the tree and stay protected; their deletion is still held in Held for the maintainer: delete the five retained v0 Go verification files and prune their protected-path entries #431.scripts/release-verify.sh: the Go consumer module now runsgo mod tidywith no-e, no output masking and no|| true. Every release dry run and every post-publish verify runs a real consumer tidy.bindingVersionis now 1.0.1, andgo/CHANGELOG.mdhas the 1.0.1 entry.Measured locally:
go mod tidy(no-e) leavesgo.mod/go.sumbyte-identical;replace) getsgo mod tidyexit 0 andgo mod tidy -diffexit 0, andgo buildsucceeds.go vet ./..., the User-Agent tests and golangci-lint (0 issues);release-verify.sh --selftestand shellcheck;policy-merge-check --check-carve-outand--check-guide;After merge:
-eagainst the local module.go/v1.0.1on that head.🤖 Generated with Claude Code
https://claude.ai/code/session_012NdkF6p8Q3qkdxKCgbdjgb