deps(frontend): jsdom 30 + testing-library/jest-dom 7 (lands #412/#409) - #426
Merged
Conversation
Bump frontend test-environment devDependencies to their next majors: - jsdom 29.1.1 -> 30.0.0 - @testing-library/jest-dom 6.9.1 -> 7.0.0 Supersedes Dependabot PRs #412 (jsdom) and #409 (jest-dom) by landing both frontend test-env majors as one reviewable change. No source or vitest config changes were required: setup already imports the framework-scoped matcher entry (@testing-library/jest-dom/vitest) that jest-dom 7 requires, and jsdom 30 works transparently under vitest 4. Refs #420 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017F63bPvWRFR4iVEm83Pzoj
CI runs `npm --prefix frontend ci` on Node 22.13.1 / npm 10.9.2, which strictly rejected the lockfile generated by this machine's npm 11: npm error `npm ci` can only install packages when your package.json and package-lock.json ... are in sync. npm error Missing: lru-cache@11.5.2 from lock file npm 11 had omitted lru-cache@11.5.2 from four nested paths (jsdom, nitro, @asamuzakjp/css-color, @asamuzakjp/dom-selector). Regenerated the lockfile with `npx npm@10.9.2 install` and validated with `npm@10.9.2 ci` (exit 0, 0 vulnerabilities). Lockfile-only change; no dependency versions altered. Refs #420 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017F63bPvWRFR4iVEm83Pzoj
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lands both frontend test-environment major upgrades as one reviewable change, per the batching plan in #420 (frontend dev-test group):
jsdom29.1.1 → 30.0.0@testing-library/jest-dom6.9.1 → 7.0.0Supersedes Dependabot PRs #412 (jsdom) and #409 (jest-dom). A human should close #412 and #409 when this merges — this PR does not close them.
What changed
frontend/package.json: the two devDependency version ranges.frontend/package-lock.json: regenerated to match.No source or vitest config changes were required. The test setup already imports the framework-scoped matcher entry that jest-dom 7 requires:
and jsdom 30 works transparently under vitest 4 (
environment: "jsdom"). jest-dom 7's type augmentation is still picked up via the existingtsconfig.jsontypes: ["…","@testing-library/jest-dom"]entry, sotsc --noEmitstays clean.Validation
Run in the worktree on the pushed tree (local Node 26; CI on Node 22.13 is the gate):
npm --prefix frontend ci→ clean, 0 vulnerabilities (strict lockfile in sync)npm --prefix frontend run test(vitest run) → 5 files, 10 tests passednpm --prefix frontend run typecheck(tsc --noEmit) → passOnly jest-dom matchers in use are
toBeInTheDocumentandtoHaveAttribute— both unaffected by the v7 major (which mainly drops legacy Node/entry-point support).Scope / non-goals
Refs #420