-
-
Notifications
You must be signed in to change notification settings - Fork 376
feat(workspace): reuse checkout opens and trim repeated bootstrap #125
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
866d49e
feat(workspace): reuse opens within ChatGPT sessions
Waishnav ff9c337
fix(workspace): keep reused cards visually stable
Waishnav 8ea171f
fix(review): restore checkpoints after restart
Waishnav e2121b4
fix(ui): expose workspace card metadata
Waishnav 44c0969
test(workspace): make reuse assertions deterministic
Waishnav f7fc11b
test(ui): remove duplicate workspace assertions
Waishnav fef5250
feat(workspace): track project bootstrap delivery
Waishnav 540d51c
fix(workspace): always create requested worktrees
Waishnav f5ab680
fix(server): separate workspace reuse from bootstrap
Waishnav b38e46c
refactor(workspace): store conversation scope ids directly
Waishnav a8701f4
fix(review): preserve partial checkpoints safely
Waishnav e13fd52
fix(workspace): preserve valid bindings on context errors
Waishnav 190b1dc
fix(ui): stringify empty diagnostics safely
Waishnav 35049a8
docs(workspace): remove unsupported reopen guidance
Waishnav 62dc7c1
fix(db): make bootstrap backfill deterministic
Waishnav ae54601
fix(workspace): canonicalize missing checkout targets
Waishnav 3597e2e
Merge origin/main into feat/reuse-chatgpt-workspaces
Waishnav 7942f2b
test(workspace): use canonical binding keys
Waishnav 7105d1d
fix(workspace): claim bootstrap after context loads
Waishnav 95b08f2
fix(review): preserve checkpoint meanings after ref loss
Waishnav 13e9fef
docs(workspace): include mode switches in reopen guidance
Waishnav ffb83de
fix(review): activate recreated baselines
Waishnav 598c737
fix(review): retry eligibility after repository changes
Waishnav 13f1464
fix(review): fall back when last-shown checkpoint is missing
Waishnav 076c7fb
test(workspace): align regressions with public seams
Waishnav File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| import assert from "node:assert/strict"; | ||
| import test from "node:test"; | ||
| import { openAiConversationScopeId } from "./request-meta.js"; | ||
|
|
||
| test("OpenAI session metadata supplies the opaque conversation scope", () => { | ||
| assert.equal( | ||
| openAiConversationScopeId({ | ||
| "openai/session": "chat-1", | ||
| "openai/subject": "user-1", | ||
| "openai/organization": "org-1", | ||
| }), | ||
| "chat-1", | ||
| ); | ||
| }); | ||
|
|
||
| test("missing or empty OpenAI session metadata has no conversation scope", () => { | ||
| assert.deepEqual( | ||
| [ | ||
| openAiConversationScopeId(undefined), | ||
| openAiConversationScopeId({}), | ||
| openAiConversationScopeId({ "openai/session": "" }), | ||
| ], | ||
| [undefined, undefined, undefined], | ||
| ); | ||
| }); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| function metadataString( | ||
| meta: Record<string, unknown> | undefined, | ||
| key: string, | ||
| ): string | undefined { | ||
| const value = meta?.[key]; | ||
| return typeof value === "string" && value.length > 0 ? value : undefined; | ||
| } | ||
|
|
||
| export function openAiConversationScopeId( | ||
| meta: Record<string, unknown> | undefined, | ||
| ): string | undefined { | ||
| return metadataString(meta, "openai/session"); | ||
| } | ||
|
coderabbitai[bot] marked this conversation as resolved.
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.