Security: fix Stripe registration payment bypass - #448
Open
polevaultweb wants to merge 2 commits into
Open
Conversation
The Stripe plan field was injected with required=false, allowing unauthenticated users to bypass payment by submitting the registration form directly without the wpum_stripe_plan POST field. The user was created without plan metadata, and the access control model treated missing metadata as paid/allowed. - Mark wpum_stripe_plan as required when Stripe products are configured - Move plan check before user creation in the AJAX registration handler - Add StripePaymentBypassTest covering field requirement and bypass path Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Cover single-product, multi-product, and filtered-options scenarios to ensure the required field works correctly in all configurations. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
wpum_stripe_planasrequired => truewhen Stripe products are configuredTest plan
StripePaymentBypassTestpasses (4 new tests)🤖 Generated with Claude Code