Plugin refactor + classifier support + idempotency - #10
Merged
Conversation
johnwaalsh
reviewed
Jul 16, 2026
| - **High-volume writes** (image metadata, provenance, index tables, image bytes) go directly to the columnar store and object store | ||
|
|
||
| This avoids coupling ingest scripts to the database while keeping high-throughput writes off the HTTP path. | ||
| This avoids coupling ingest scripts to the database while keeping high-throughput writes off the HTTP path. Low-volume producers that prefer not to depend on the columnar store directly can post small provenance batches over REST (`POST /images/provenance/batch`, one instrument per batch). |
Member
There was a problem hiding this comment.
I wonder if there's a way we could further describe the difference between low-volume and high-volume producers. Perhaps some examples of what kind of data would be best for the REST API, and what kind of data would be best for the columnar store?
Collaborator
Author
There was a problem hiding this comment.
Yes, this could be elucidated further. The primary use case would be for data coming in small batches in near-real time.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Plugin refactor + classifier support + idempotency
Refactors the plugin system to use dependency injection so the core never imports plugins at load time. Plugins are now generic and parameterized; instrument-specific presets (IFCB features, IFCB CNN classification) move under
improv.plugins.ifcband pin akind/index_tableonto a generic plugin. Adds machine classification support end-to-end and makes provenance/index writes idempotent.Highlights
store/indexes.pyremoved,store/dedup.pyadded.002_classifier_taxonomymigration.(image_id, kind, source, data_hash)using RFC 8785 (JCS) canonical hashing (newrfc8785dep). Backend-agnostic (VAST DB / DuckDB+Parquet).POST /images/provenance/batchlets low-volume producers write provenance over REST without depending on the columnar store (one instrument per batch).ImprovClientgains taxonomy registration.timestamp).Review note: client contract —
timestampmust be event time, not wall-clock-at-send, or retries won't dedup.