Fix WebDAV PROPPATCH method and KeyError on invalid client paths - #34
Conversation
- Add PROPPATCH HTTP method handling in asgidav returning 207 Multi-Status - Safely handle invalid client names and path parsing in WebDAV _get_member to return 404 instead of raising KeyError Co-authored-by: VulcanoSoftware <113239901+VulcanoSoftware@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
- Add PROPPATCH HTTP method handling in asgidav returning 207 Multi-Status - Safely handle invalid client names and path parsing in WebDAV _get_member to return 404 instead of raising KeyError - Fix mypy typing errors in asgidav/reqres.py Co-authored-by: VulcanoSoftware <113239901+VulcanoSoftware@users.noreply.github.com>
- Add PROPPATCH HTTP method handling in asgidav returning 207 Multi-Status - Safely handle invalid client names and path parsing in WebDAV _get_member to return 404 instead of raising KeyError - Fix ruff S110 lint rule in asgidav/reqres.py by catching specific XML syntax and value errors Co-authored-by: VulcanoSoftware <113239901+VulcanoSoftware@users.noreply.github.com>
1 participant
Fixes 500 Internal Server Error when WebDAV clients request invalid top-level paths (such as /webdav/favicon.ico) by returning 404 Not Found, and adds support for the PROPPATCH HTTP method returning 207 Multi-Status to allow WebDAV clients (like CarotDAV) to upload files successfully.
PR created automatically by Jules for task 9593268536382365868 started by @VulcanoSoftware