(test) add unit tests for installer app hint logic#33
Open
avatGit wants to merge 1 commit into
Open
Conversation
|
Thanks for your first pull request to Sifty! A couple of things that help it land quickly: Sifty deletes files, so all deletion must go through |
e0878a0 to
95451d0
Compare
|
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
As requested, this PR adds unit tests for the pure helper functions in
src/sifty/core/junk.pythat handle the installer app gating logic.Changes
test_installer_app_hint_strips_suffixesto verify version and architecture cleaning.test_is_installed_app_installer_matches_substringsto validate bidirectional substring matching using afrozenset.test_is_installed_app_installer_under_3_chars_guardto ensure the short-hint safety guard works perfectly.Closes #29
Safety checklist
Sifty deletes files, so every PR keeps these promises:
pytestis green, includingtests/test_safety.pyos.remove,shutil.rmtree,Path.unlink); everything goes throughsafety.trash()