feat(bridge): render markdown in the Windows tray meeting-summary window#178
Open
Vortiago wants to merge 2 commits into
Open
feat(bridge): render markdown in the Windows tray meeting-summary window#178Vortiago wants to merge 2 commits into
Vortiago wants to merge 2 commits into
Conversation
The per-meeting window showed the LLM summary in a read-only TextBox, so raw markdown (`## Decisions`, `- bullet`, `**owner**`) appeared as literal markup and was hard to read. Render it instead, mirroring the web dashboard's minimal markdown subset. - SummaryMarkdown (Core, net10.0, no WinForms): pure parser of the same subset the web renderMarkdown supports (#..###### headings, -/* bullets, 1./1) numbered, fenced code, paragraphs, inline `code`/**bold**/*italic*), plus a Plain() wrapper for non-markdown status/failure lines. Exhaustively unit-tested on the Linux/CI cross-platform job. - SummaryRichText (TrayBridge): paints the block model onto a read-only RichTextBox with styled runs — no new dependency, no WebView2 runtime. - MeetingFormView gains a BodyIsMarkdown signal (true only for the Done summary) so the shell never reinterprets a plain status / recorder-error line as markdown. - MeetingForm: TextBox -> RichTextBox; Copy yields the raw markdown source; the per-tick Apply re-renders only when the body actually changes.
Replace the per-line trailing-'\r' strip with an up-front Replace("\r\n","\n")
so the loop iterates the normalised line directly. Removes the foreach
loop-variable remap CodeQL flagged (cs/linq/missed-select) and is behaviour-
equivalent — a lone '\r' still stays literal within a line, matching the web
renderer's /\r?\n/ split. The CRLF parse test still pins the equivalence.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The Windows tray bridge's per-meeting window showed the LLM summary in a read-only
TextBox, so the raw markdown (## Decisions,- bullet,**owner**,`api/tap`) appeared as literal markup — hard to read. The backend serves the summary as raw markdown (it never pre-renders HTML), and the web dashboard already renders a small, deliberately-minimal markdown subset. This brings the same readability to the tray window.What
SummaryMarkdown(TapScribe.Bridge.Core,net10.0, no WinForms): a pure parser of the same subset the webrenderMarkdown/_inlineMdsupports —#–######headings,-/*bullets,1./1)numbered (renumbered sequentially), fenced``` code blocks (verbatim), paragraphs, and inline`code`/`bold`/`italic` (flat, no nesting). Includes a `Plain()` wrapper for non-markdown status/failure lines. Exhaustively unit-tested on the Linux/CI cross-platform job.SummaryRichText(TapScribe.TrayBridge): paints the block model onto a read-onlyRichTextBoxwith native styled runs — heading fonts, bullet/number prefixes, bold/italic, monospace code. No new dependency, no WebView2 runtime (a plain static helper, not aControlsubclass, so it never trips WFO1000).MeetingFormViewgains aBodyIsMarkdownsignal (true only for the Done summary) so the dumb WinForms shell routes markdown-vs-plain explicitly and a raw recorder error line can't be reinterpreted as markdown.MeetingForm:TextBox→RichTextBox; Copy now yields the raw markdown source (clean to paste into markdown-aware tools); the per-tickApplyre-renders only when the body actually changes.Design notes
tapscribe/web/js/templates.js) so the two stay in conceptual sync; they remain independent JS/C# implementations (no shared code across the boundary).PipelineView/StatusView/MeetingFormViewpattern.RichTextBoxchosen over WebView2 to avoid a runtime dependency for a deliberately tiny markdown subset.Testing
dotnet test tests/TapScribe.Bridge.Core.Tests— 250 pass (newSummaryMarkdownTests+MeetingFormViewBodyIsMarkdownassertions; existing tests unchanged). Mirrors the CI ubuntu cross-platform job.dotnet build TapScribe.WindowsTrayBridge.slnx -c Release -p:EnableWindowsTargeting=true— clean, 0 warnings (mirrors the Windows compile job)./simplify(reuse/simplification/efficiency/altitude) and/code-review(xhigh).🤖 Generated with Claude Code