fix: hide the fade and the blend when there is nothing to compare - #399
Merged
nGervasyuk merged 1 commit intoAug 23, 2026
Merged
nGervasyuk merged 1 commit into
nGervasyuk merged 1 commit into
Conversation
Both controls read a checkpoint against its baseline, so they only mean something when the two differ. A new run has no baseline behind it at all — that is the pane reading 'No image available' while the fade still offers to reveal it — and an ok run matched the baseline it has. Everything else keeps them: an unresolved run under review, a dimension mismatch, where fading is the only comparison left since no diff could be produced, and an approved run, which keeps the diff it was approved with and is still worth looking at. The two tests that walk to the next screenshot now step onto another run under review, since a settled one no longer carries a fade to forget.
nGervasyuk
force-pushed
the
fix/hide-fade-when-settled
branch
from
August 21, 2026 07:17
7744960 to
dae094d
Compare
nGervasyuk
changed the title
|
This was referenced Aug 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The fade slider and the difference blend are offered on every screenshot, including ones where there is nothing to compare. On a new run the baseline pane reads "No image available" — and the fade still invites you to reveal a baseline that isn't there. An ok run matched the baseline it has, so fading between the two shows nothing either.
Change
Show both controls only when the checkpoint has a baseline it differs from:
newokunresolvedunresolved, no diffapproved/autoApprovedThe predicate lives next to the other status helpers as
canCompareToBaseline, so the rule is stated once and covered by unit tests.Gating on
diffName— the condition the diff toggle uses — would have been wrong in both directions: it would drop the controls on a dimension mismatch, where they are the only way left to compare, and it says nothing about a run that matched its baseline.Tests
canCompareToBaseline: under review, dimension mismatch, approved, autoApproved, ok, new, and no baselineFull Playwright suite (87) and unit suite (26) pass locally.
Nothing to configure. Independent of the other open frontend PRs (#397, #398, #399, #400, #401) — verified that they all merge onto
masterin sequence without conflicts, in any order.