Repository navigation
Declare distributed outputs and clarify scenario authoring - #216
Merged
Merged
Conversation
Use typed object IDs for selectors, scopes, graph nodes, and editor operations. Keep display names optional and nonunique while preserving application and instance identities. Update documentation, examples, packaged guidance, and regression tests.
VEZY
marked this pull request as ready for review
September 16, 2026 12:43
Updates the requirements on [CSV](https://github.com/JuliaData/CSV.jl) to permit the latest version. Updates `CSV` to 1.0.0 - [Release notes](https://github.com/JuliaData/CSV.jl/releases) - [Commits](JuliaData/CSV.jl@v0.10.0...v1.0.0) --- updated-dependencies: - dependency-name: CSV dependency-version: 1.0.0 dependency-type: direct:production dependency-group: all-julia-packages ... Signed-off-by: dependabot[bot] <support@github.com>
…inty propagation in its own page
…dex/bonito-docs-logo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cross-object outputs now belong to the model's
outputs_declaration, usingDistributed(Default(...))orDistributed(Required(...)). Scenarios choose destinations with anonymousOutputToentries, and kernels request destination columns by variable name. This keeps a model's output definitions separate from the choice of plants or organs that receive them.The compiler validates destination declarations, required initial values, and output ownership. A single destination can infer its variables; multiple destinations must explicitly partition them. The graph editor, generated scenarios, tests, benchmarks, examples, and authoring skill use the same API.
This PR also:
Authoring.validate_scenario, while retaining structured diagnostic details.This is an intentional API change: distributed output defaults and requirements move out of scenario destination declarations and into model schemas. Existing scenarios and kernels must use the new
OutputToandoutput_targetsforms documented here.Validation
The full local Julia package suite passed on
520d903: 5,579 tests, zero failures or errors, using an unfiltered Kaimon-managed package test run. Frontend type checking and all 25 frontend tests passed. The full local documentation build and static-export validation passed for 58 pages, together with three documentation-renderer regression tests.On GitHub, the graph editor browser tests, documentation build, and all three downstream integrations (XPalm, PlantGeom, and PlantBiophysics) passed on
520d90387c4042c541ef122e92b0e73b553f01d4. The XPalm pass confirms that this API resolves the mismatch seen when current XPalm is tested against the older API in #215.Julia 1.10 CI exposed four allocation-test failures: the measurement included 64/160 bytes of boxing at the test's dynamic call site. A local reproduction confirmed that the assignment itself allocates zero bytes. Commit
1f6cda76moves the measurement into a function with concrete argument types, keeping all zero-byte assertions and value checks unchanged. The complete output-target API test file then passed 215/215 on both Julia 1.10.11 and 1.12.1. No runtime code changed for this fix; the full package suite was not repeated locally after this test-only correction.The final merge from
mainchanges merge history only: its tracked files are identical to1f6cda76. GitHub CI has restarted for final head2a1084fe058db0c62bbece6e01e6d5b56add0b52; those results are separate from the completed checks above.The benchmark workflows still fail during dependency resolution before taking measurements. They do not provide a performance result for this PR.