Match legacy class->instance query inheritance in term_info#63
Merged
Conversation
Reinstate the type-based gate from the legacy term-info builder (uk.ac.vfb.geppetto VFBProcessTermInfoCachedJson) so an Individual of an anatomical or expression-pattern type inherits its parent class's full query menu, anchored on the class. Replace the Technique == "computer graphic" heuristic, which only caught painted domains and dropped confocal instances such as expression patterns (VFB_00020530), splits (VFB_00069525), tracts and muscle. Drive inheritance from a predicate table mirroring the class-menu criteria, anchored on the primary parent class (parents[0]), so an instance shows exactly what its class shows. Add live-integration parity tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reinstates the type-based instance->class query inheritance from the legacy term-info builder (uk.ac.vfb.geppetto VFBProcessTermInfoCachedJson), replacing the Technique == "computer graphic" heuristic that only caught painted domains.
An Individual of an anatomical/expression-pattern type now inherits its parent class's full query menu, anchored on the class - so e.g. R40G10 (VFB_00020530) and confocal splits (VFB_00069525), tracts and muscle images regain their class queries instead of showing an empty menu.
Follow-up: eyeball a confocal Neuron_projection_bundle and a Muscle instance on the live site; consider DRYing the duplicated class-menu/predicate conditions