[No0ne558]

A code audit with its fixes, a Reports screen that leaves room for the report, and better ways to manage menu and retail items. One commit per change, each with tests; the audit's findings are written up in modern/docs/AUDIT-2026-10.md.

Audit fixes

• Tax: a percent discount lowered the tax on lines it didn't come off ($10 food and $10 wine that can't be discounted, 50% off, taxed each on $7.50). With discounts capped at the items total, each discount's line on the receipt is now capped too.
• Database: a row SQLite would always refuse no longer stops every later write: after five tries it goes to <database>.unsaved.jsonl and the manager is told; retries back off. Migration 13 (cash tips column) is one transaction, and a database left half-migrated by it opens. Indexes for lookups by time (made on opening, not a schema version, so a standby a version behind still opens it).
• Standby: only plain table and column names go into SQL; five wrong take-over PINs and it waits (30 s, doubling to 15 min).
• Network: a long message arriving in pieces isn't searched again from its start; a runaway line on the standby and pairing connections closes it. Terminals back off to 10 s between tries and give up a try after 10 s. Discovery ignores an impossible port.
• Offline: a screen's check sent again after End of Day isn't booked twice.
• Manager screens: numbers with a comma for the decimals ("18,5").
• Import: a sheet with Cost and Price columns takes the price as the price.
• Scanning: a UPC read as EAN-13 (a 0 in front) rings the item in on the order screen.
• Page editor: "Opens on" lists every report.

Left for a decision (changes saved data or a larger rework), in the write-up: past tax worked out at today's rates in range reports, doubles in labor/tip pool/stock math, the standby copy and some reads on the main thread, adminChanged refreshing 33 properties, the kitchen display rebuilding every card.

Reports

• The reports are a list by kind (Sales, Staff, Money, Stock, Guests, Checks) in the column that was empty beside the report; on a phone, one key with the report's name opens it over the report.
• The days are one row to slide, folded away while reading further down. Multi-day choices are dimmed for one-day reports, and picking one goes back to Day (it showed Sales before).
• A swipe across the report goes to the next or previous one; tables wider than the screen slide sideways; value columns fit what's in them.

Menu and retail items

• ☰ List in the Menu Builder: every item in one table (name, category, price, tax, number/barcode), sorted by a heading, narrowed to a category, sold out or no code. Find matches any part of a name, number, barcode, category or kitchen name, with no limit.
• Select → Price… / Tax…: set one price, or move each item's price by an amount or a percent (with a before → after check); set the tax for all. One Undo each.
• More… opens the Menu panel on that item.
• Track stock on the card: On hand, Low at, Cost (and margin). An ingredient of the item's own behind it, so sales count it down (a shop's too), void puts it back, sold out at none, Count Stock, deliveries and the Stock report all work.
• A code nothing has, scanned with a manager on: Add an Item With It opens a new card with that barcode.
• Export → As a Spreadsheet (.csv), under headings Import… reads back.
• Hand-built menu pages: a new item's button goes by itself on the page with its category's items.

Tests

The full suite (681 test cases) passes locally on Ubuntu 26.04 with Qt 6.10. New tests cover each fix and feature; translations for es, fr, pt and zh are included (tools/i18n.py check clean).

🤖 Generated with Claude Code

https://claude.ai/code/session_015JJaarV4sfTKegR57HYFZ8