Log profile name on sessions - #163
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Team Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review. 📝 WalkthroughWalkthroughSession logging now records the resolved credential profile. New schemas define the profile column, existing databases receive it through migration, and session creation persists the supplied value. The run command passes the active profile, with tests covering storage and migration. ChangesSession Profile Persistence
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🔵 Low · up to This change records the active profile for each session and migrates existing local databases. It is mergeable with owner awareness because concurrent or interrupted migrations could temporarily prevent a session from opening, although normal sequential retries recover and no credential or authorization behavior is changed. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fb954cad60
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Adds support for tracking the active profile used during a session in the session logging system. It updates the session database schema, ensures backward compatibility with existing databases, and adds tests for the new behavior.
Summary by CodeRabbit