Skip to content

Log profile name on sessions - #163

Merged
nezhar merged 1 commit into
mainfrom
log-profile
Sep 1, 2026
Merged

Log profile name on sessions#163
nezhar merged 1 commit into
mainfrom
log-profile

Conversation

@nezhar

@nezhar nezhar commented Aug 31, 2026

Copy link
Copy Markdown
Collaborator

Adds support for tracking the active profile used during a session in the session logging system. It updates the session database schema, ensures backward compatibility with existing databases, and adds tests for the new behavior.

Summary by CodeRabbit

  • New Features
    • Session records now include the active credential profile.
    • Existing session databases are automatically updated to support profile tracking.
  • Bug Fixes
    • Improved session metadata consistency by recording the resolved profile whenever a session starts.

@coderabbitai

coderabbitai Bot commented Aug 31, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Team

Run ID: f270137d-af60-4371-b536-c1b20dfe2a49

📥 Commits

Reviewing files that changed from the base of the PR and between ac27ed9 and fb954ca.

📒 Files selected for processing (3)
  • src/vibepod/commands/run.py
  • src/vibepod/core/session_logger.py
  • tests/test_session_logger.py

Included review availability: Your plan provides up to 2 included reviews per hour; 1 remains after this review.


📝 Walkthrough

Walkthrough

Session logging now records the resolved credential profile. New schemas define the profile column, existing databases receive it through migration, and session creation persists the supplied value. The run command passes the active profile, with tests covering storage and migration.

Changes

Session Profile Persistence

Layer / File(s) Summary
Session schema and migration
src/vibepod/core/session_logger.py, tests/test_session_logger.py
SessionLogger.open_session requires a profile, adds the profile column to new schemas, migrates existing sessions tables, and stores the supplied value. Tests verify persistence and migration.
Profile wiring and compatibility tests
src/vibepod/commands/run.py, tests/test_session_logger.py
The run command passes active_profile to open_session. Existing tests pass the new profile argument.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: 🔵 Low · up to fb954

This change records the active profile for each session and migrates existing local databases. It is mergeable with owner awareness because concurrent or interrupted migrations could temporarily prevent a session from opening, although normal sequential retries recover and no credential or authorization behavior is changed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 30.77% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 13 functions across 3 files. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: storing the profile name on sessions.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch log-profile

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: fb954cad60

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread src/vibepod/core/session_logger.py
Comment thread src/vibepod/core/session_logger.py
@nezhar
nezhar merged commit 14cb87b into main Sep 1, 2026
69 of 70 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant