Repository navigation
feat: read uncovered lines from the test result, require very_good_cli 1.5.0 - #177
Merged
Merged
Conversation
The MCP `test` tool exposes `show_uncovered` as of very_good_cli 1.5.0, so its result carries the per-file `Lines not covered:` block the coverage gate used to reconstruct by parsing `coverage/lcov.info`. - Pass `show_uncovered: true` alongside the other coverage parameters - Rank fix targets from the result; the lcov parse is now the fallback for a result without the block - Soften the "Bash is reserved for parsing lcov" carve-out accordingly Closes #146
green-gate now relies on `show_uncovered` on the MCP `test` tool, which the CLI only exposes from 1.5.0. Raise the single floor in `vgv-cli-common.sh` so the version checks match what the skills call, and update the test fixtures and the docs that quote the floor.
ryzizub
marked this pull request as ready for review
October 13, 2026 10:32
marcossevilla
approved these changes
Oct 13, 2026
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #146
green-gatereconstructed per-file coverage gaps by parsingcoverage/lcov.info.The MCP
testtool has exposedshow_uncoveredsince very_good_cli 1.5.0, so theresult the skill already has carries them. The skill now passes
show_uncovered: true, ranks fix targets from the result'sLines not covered:block, and keeps the lcov parse as the fallback.
Raises the CLI version floor 1.3.0 → 1.5.0 in
vgv-cli-common.sh, since the skilldepends on that parameter.
The issue asked for a
very_good.yamlinstead, because 1.4.0 lacked the MCPparameter; 1.5.0 has it, which the issue names as the better route.
Type of Change
feat)fix)refactor)docs)ci)chore)🤖 Generated with Claude Code