Inline append already applied - #857
Merged
Merged
Conversation
A multi-targeted project transitioning to inline snapshots fails the same call site under every framework, and each one queues an append. Accepting the first writes the literal the rest are still carrying, so the second accept found a Snapshot call in the way and refused - reporting a failure over a source file that was already right, and sending the reader off to re-run a test with nothing left to say. TryAppend now reads the chained call's argument before refusing. Same content is AlreadyApplied; different content is still NotFound, since that one genuinely cannot say what it wants until it has been re-run against the literal now in the source. Compared by value rather than by text, so a literal written in another shape still counts and F# answers as C# does despite the layout of its triple quoted literal. WalkChain reports the position of the call it found rather than the fact of it, because a caller deciding what to do about one has to read its argument.
docs/inline.md is generated, so the paragraph was written into the output and the next build stripped it back out. It belongs in the mdsource the generator reads; the generated file is unchanged either way.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.