Add DiffRunner.TrayDisabled - #854
Merged
Merged
Conversation
Pending moves and deletes go to a running tray from inside the test process, and nothing turned that off on its own. Disabling diff is not the same switch: it does not stop the tracking either, since every exit of InnerLaunch adds the move, Disabled included; and in Verify it turns off the inline staging that a suite testing that staging exists to produce. So a suite that has to leave diff on collected a pending move per staged snapshot per run on any developer box with a tray, each pointing at a throwaway directory and each offering an accept that would write to it. DiffEngine.Tests already cut both routes for itself, but half of that - DiffEngineTray.IsRunning - is internal, so no consumer could. TrayDisabled is the public half, read from DiffEngine_TrayDisabled until set and pinned after, as Disabled is. PendingFiles now gates all six sends through one TrayAvailable, so opting out cannot cover only some of them.
This was referenced Aug 26, 2026
Bump DiffEngine from 20.0.0-beta.34 to 20.1.1
NServiceBusCommunity/NServiceBus.Community.Serilog#901
Closed
This was referenced Aug 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pending moves and deletes go to a running tray from inside the test process, and nothing turned that off on its own. Disabling diff is not the same switch: it does not stop the tracking either, since every exit of InnerLaunch adds the move, Disabled included; and in Verify it turns off the inline staging that a suite testing that staging exists to produce.
So a suite that has to leave diff on collected a pending move per staged snapshot per run on any developer box with a tray, each pointing at a throwaway directory and each offering an accept that would write to it. DiffEngine.Tests already cut both routes for itself, but half of that - DiffEngineTray.IsRunning - is internal, so no consumer could.
TrayDisabled is the public half, read from DiffEngine_TrayDisabled until set and pinned after, as Disabled is. PendingFiles now gates all six sends through one TrayAvailable, so opting out cannot cover only some of them.