Load the committed linux-x64 binary somewhere - #838
Merged
Conversation
The native job exists to test what actually ships, because both test jobs build the shim from source and overwrite the committed binary before testing. Its matrix held osx-arm64 and linux-arm64 only, so the one RID it left out - linux-x64, the one most people run - was loaded by no job at all. A rebuild that was never merged, a file corrupted by a text mode checkout, or an unsatisfied runtime dependency would have shipped unnoticed there, which is the exact class of failure the job's own comment says it is for.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The native job exists to test what actually ships, because both test jobs build the
shim from source and overwrite the committed binary before testing. Its matrix held
osx-arm64 and linux-arm64 only, so the one RID it left out - linux-x64, the one most
people run - was loaded by no job at all. A rebuild that was never merged, a file
corrupted by a text mode checkout, or an unsatisfied runtime dependency would have
shipped unnoticed there, which is the exact class of failure the job's own comment
says it is for.