Keep what a wheel message leaves over - #834
Merged
Merged
Conversation
The canvas divided each wheel message by 120 and dropped the remainder. A wheel click sends exactly 120 so that worked, but a precision touchpad sends a fraction of one per message - ten to sixty for ordinary two finger movement - and every one of those divided to zero. So scrolling the panes with a touchpad did nothing at all, while the docked scrollbar beside them worked, that one accumulating internally. WheelNotches keeps the remainder between messages, and is its own type for the reason QueueTips is: the thing that matters is an accumulation across messages, and that can be tested where a window cannot. The Windows head only. The same fault is in the Mac and Linux heads, in native/swift and native/src, and fixing those means rebuilding and committing the binaries, which is a change of its own.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The canvas divided each wheel message by 120 and dropped the remainder. A wheel
click sends exactly 120 so that worked, but a precision touchpad sends a fraction of
one per message - ten to sixty for ordinary two finger movement - and every one of
those divided to zero. So scrolling the panes with a touchpad did nothing at all,
while the docked scrollbar beside them worked, that one accumulating internally.
WheelNotches keeps the remainder between messages, and is its own type for the
reason QueueTips is: the thing that matters is an accumulation across messages, and
that can be tested where a window cannot.
The Windows head only. The same fault is in the Mac and Linux heads, in
native/swift and native/src, and fixing those means rebuilding and committing the
binaries, which is a change of its own.