Leave the window command for a surface that has a window - #817
Merged
Conversation
The stashed Focus or Close was taken by whichever listing arrived first, including a plain List. That one is the documented IDE plugin API - InlineQueueClient.TryListKeys - and has no window to raise, so taking the command threw it away: the plugin could do nothing with what it was handed, and the attached viewer polling beside it never raised for the new snapshot. Only a listing that carries patches takes it, which is the one a viewer asks for. A plain listing now reads through without clearing the stash.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The stashed Focus or Close was taken by whichever listing arrived first,
including a plain List. That one is the documented IDE plugin API -
InlineQueueClient.TryListKeys - and has no window to raise, so taking the
command threw it away: the plugin could do nothing with what it was handed, and
the attached viewer polling beside it never raised for the new snapshot.
Only a listing that carries patches takes it, which is the one a viewer asks
for. A plain listing now reads through without clearing the stash.