Expand the viewer's search directory on Linux and macOS - #804
Merged
Conversation
WildcardFileFinder expands with Environment.ExpandEnvironmentVariables, which only understands %NAME%. The Linux and macOS entries were written shell style as $HOME/.dotnet/tools/, so that string was passed through untouched and named a literal directory called "$HOME" - which nothing has. A globally installed DiffEngineViewer was therefore invisible on those platforms. It only mattered when the bundled copy was absent, which is exactly the case the dotnet tool install exists to cover. The test asserts no definition anywhere uses the shell syntax, rather than this one entry, since the mistake is easy to repeat and the two syntaxes look equally plausible in a path. Generated docs regenerated to match.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WildcardFileFinder expands with Environment.ExpandEnvironmentVariables, which
only understands %NAME%. The Linux and macOS entries were written shell style as
$HOME/.dotnet/tools/, so that string was passed through untouched and named a
literal directory called "$HOME" - which nothing has.
A globally installed DiffEngineViewer was therefore invisible on those
platforms. It only mattered when the bundled copy was absent, which is exactly
the case the dotnet tool install exists to cover.
The test asserts no definition anywhere uses the shell syntax, rather than this
one entry, since the mistake is easy to repeat and the two syntaxes look equally
plausible in a path.
Generated docs regenerated to match.