Give the terminate tests a margin, without letting them stop failing - #797
Merged
Conversation
Both asserted WaitForExit(1000) after terminating a process. One second is a bet on the runner being idle, and on a loaded two core Windows runner it is not: the pair went red on main, and a re-run with no code change went green. Widening alone would have been wrong for the non-windowed case. That FakeDiffTool sleeps five seconds and then exits by itself, so any wait past five seconds passes whether the process was terminated or merely ran out - the same trap LaunchAndKill was in. So that one also asserts the exit code: TryTerminateProcess passes -1 to TerminateProcess, and running out returns 0. The windowed case needs no such guard, since a windowed FakeDiffTool runs until something closes it. Waiting longer there cannot turn a failure into a pass. Checked by making TryTerminateProcess skip the terminate: both tests fail, one on the exit code and one on the wait.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both asserted WaitForExit(1000) after terminating a process. One second is a bet
on the runner being idle, and on a loaded two core Windows runner it is not: the
pair went red on main, and a re-run with no code change went green.
Widening alone would have been wrong for the non-windowed case. That
FakeDiffTool sleeps five seconds and then exits by itself, so any wait past five
seconds passes whether the process was terminated or merely ran out - the same
trap LaunchAndKill was in. So that one also asserts the exit code:
TryTerminateProcess passes -1 to TerminateProcess, and running out returns 0.
The windowed case needs no such guard, since a windowed FakeDiffTool runs until
something closes it. Waiting longer there cannot turn a failure into a pass.
Checked by making TryTerminateProcess skip the terminate: both tests fail, one
on the exit code and one on the wait.