Let a staging clear be scoped to the framework that settled - #789
Merged
Conversation
InlineQueue.Settle is origin scoped, and the reason is on it: a framework that starts passing removes only its own label, so the other framework's still failing content stays reviewable. InlineStaging.Clear had no way to say the same thing, and staging is the same situation - one call site stages one trio per framework. So in a net8.0;net10.0 run with no queue owner, where net10 starts passing and net8 does not, net10's settle deleted net8's trio beside its own. That snapshot was then pending nowhere at all: not staged, and not in a queue either, because the reason it was staged is that nothing owned one. Additive rather than a change of behaviour. Clear takes an optional origin; passing none clears every framework's trio exactly as before, which is what a retire wants - the call site is not an inline snapshot in any framework any more - and is why ClearRemovesEveryFrameworksTrio still passes unchanged. A trio staged with no framework label is cleared either way, since there is nothing to scope it by and leaving it would strand it. Callers that want the queue's semantics can now ask for them; the decision about which of the two a producer should pass stays with the producer.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
InlineQueue.Settle is origin scoped, and the reason is on it: a framework that
starts passing removes only its own label, so the other framework's still
failing content stays reviewable. InlineStaging.Clear had no way to say the same
thing, and staging is the same situation - one call site stages one trio per
framework.
So in a net8.0;net10.0 run with no queue owner, where net10 starts passing and
net8 does not, net10's settle deleted net8's trio beside its own. That snapshot
was then pending nowhere at all: not staged, and not in a queue either, because
the reason it was staged is that nothing owned one.
Additive rather than a change of behaviour. Clear takes an optional origin;
passing none clears every framework's trio exactly as before, which is what a
retire wants - the call site is not an inline snapshot in any framework any
more - and is why ClearRemovesEveryFrameworksTrio still passes unchanged. A trio
staged with no framework label is cleared either way, since there is nothing to
scope it by and leaving it would strand it.
Callers that want the queue's semantics can now ask for them; the decision about
which of the two a producer should pass stays with the producer.