Do not swallow a trailing comment into the argument - #783
Merged
Conversation
TrimSpan's trailing loop trimmed whitespace before asking whether a comment ended where it was looking. A line comment's span includes the newline that ends it, so the first thing trimmed was that newline - after which nothing ended at `end` any more, the comment check never matched, and the comment stayed inside the argument span. The argument then was not a string literal, and the snapshot could not be patched at all: "The expected argument of the Snapshot call near line N is not a string literal", for a call that is perfectly ordinary apart from having a comment after it. Ask about the comment first. The two cases only collide when a comment ends exactly where the scan is looking and the character before it is that comment's own newline, which is precisely the shape that failed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrimSpan's trailing loop trimmed whitespace before asking whether a comment
ended where it was looking. A line comment's span includes the newline that ends
it, so the first thing trimmed was that newline - after which nothing ended at
endany more, the comment check never matched, and the comment stayed insidethe argument span.
The argument then was not a string literal, and the snapshot could not be
patched at all: "The expected argument of the Snapshot call near line N is not a
string literal", for a call that is perfectly ordinary apart from having a
comment after it.
Ask about the comment first. The two cases only collide when a comment ends
exactly where the scan is looking and the character before it is that comment's
own newline, which is precisely the shape that failed.