Do not lex a verbatim string as a raw string - #772
Merged
Conversation
TrySkipStringLike measured the quote run before checking whether the literal was verbatim, so a verbatim string opening on an escaped quote came out as a 3-quote raw string. There is no verbatim raw form: after @" a run of quotes is content. The consequence was not a mis-parse of that one literal. A raw string ends at the next run of at least as many quotes, and there is none, so the scan ran to the end of the file and every Snapshot call below the line disappeared. A test file with a Windows path in a verbatim string above its snapshots could not have any of them patched, reporting only "Could not find a Snapshot call near line N". CsStringLiteral.TryScan and FsLanguage both ask this question before measuring, and say why in a comment; the lexer was the one place that did not.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
TrySkipStringLike measured the quote run before checking whether the literal was verbatim, so a verbatim string opening on an escaped quote came out as a 3-quote raw string. There is no verbatim raw form: after @" a run of quotes is content.
The consequence was not a mis-parse of that one literal. A raw string ends at the next run of at least as many quotes, and there is none, so the scan ran to the end of the file and every Snapshot call below the line disappeared. A test file with a Windows path in a verbatim string above its snapshots could not have any of them patched, reporting only "Could not find a Snapshot call near line N".
CsStringLiteral.TryScan and FsLanguage both ask this question before measuring, and say why in a comment; the lexer was the one place that did not.