Require InlinePatch.TestName - #756
Merged
Merged
Conversation
The viewer labels and groups queue entries by TestName and falls back to the call site without one, so a producer that never set it was indistinguishable from a test with no name. Verify was that producer, and it went unnoticed until a queue of bare file:line rows made someone ask why. Required rather than non-null. A patch that never reaches a queue -- a Remove, or an apply straight through InlineApplier -- has no reviewable identity, and now says so with an explicit null instead of by omission. InlinePatchFile.TryParse was the only production construction site and already used an object initializer, so nothing outside tests changed. Test files where no patch is ever queued state the null once in a local helper rather than at every call site; helpers that already threaded framework gained a testName beside it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The viewer labels and groups queue entries by TestName and falls back to the call site without one, so a producer that never set it was indistinguishable from a test with no name. Verify was that producer, and it went unnoticed until a queue of bare file:line rows made someone ask why.
Required rather than non-null. A patch that never reaches a queue -- a Remove, or an apply straight through InlineApplier -- has no reviewable identity, and now says so with an explicit null instead of by omission.
InlinePatchFile.TryParse was the only production construction site and already used an object initializer, so nothing outside tests changed. Test files where no patch is ever queued state the null once in a local helper rather than at every call site; helpers that already threaded framework gained a testName beside it.