Inline fluent - #731
Merged
Merged
Conversation
Inline snapshots are moving from a dedicated VerifyInline entry point to a global mode plus a .Snapshot(expected) terminator, so the patcher has to work against a different call shape: * The literal is now the first argument of Snapshot rather than the second of VerifyInline, so InsertOrCheck sets argument zero. * Append adds a .Snapshot(...) call to a verify invocation that has never had one. Snapshot terminates the chain, so it lands after anything already chained on, not at the invocation's own closing paren. * Remove strips the call, along with the whitespace and line break it sat on, for when inline is switched off and the snapshot migrates back to a file. InlinePatch carries the mode and InlinePatchFile bumps to version 2 to hold it. Remove is a configuration change with nothing to review, so both the viewer's message handler and DiffRunner.AddInlineAsync refuse it; it is applied in process through InlineApplier instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.