[Feature] [Auth]: Require login redirect with callback for guest access - #194
Merged
Conversation
- Update studio proxy to redirect unauthenticated visitors without guest cookie to /login with callbackURL, bypassing /share, /api, static files, and _next - Remove automatic guest cookie assignment in studio proxy - Update portfolio proxy to guard private dashboard and editor routes against unauthenticated users without guest cookie - Update login page guest access action to set veriworkly-guest-mode=true on shared domain and redirect to callbackURL - Update portfolio store to gracefully handle 401 rejections during loadWorkspace without syncing local drafts to cloud and guard publish - Update unit and contract tests in studio and portfolio apps
…1/404 loadWorkspace
Gautam25Raj
added
enhancement
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #175
Summary of Changes
Studio Proxy (
apps/studio/proxy.ts):veriworkly-guest-mode=true) to/loginwithcallbackURLpreserving path and query./login,/share,/api, static files, and_next./admin,/profile/master,/profile/advanced).Portfolio Proxy (
apps/portfolio/proxy.ts):veriworkly-guest-mode=true) for private routes (/dashboard,/editor,/preview,/settings,/analytics,/profile,/billing).${siteConfig.links.app}/login?callbackURL=..../,/pricing,/portfolios,/user,/portfolio,/templates,/faq) accessible without auth or guest cookies.Login Page Guest Access (
apps/studio/app/login/page.tsx):veriworkly-guest-mode=truecookie on the shared domain (.localhostor.veriworkly.com).getSafeAuthCallback(callbackURL)handling cross-origin destinations viawindow.location.href.Portfolio Store (
apps/portfolio/store/portfolio-store.ts):loadWorkspace, gracefully handle 401/404 rejections by transitioning to guest mode with local cached state without throwing unhandled exceptions or attempting cloud database synchronization.publish()andunpublish()actions against unauthenticated guests.Testing & QA:
apps/studioandapps/portfolio.