Repository navigation
Phase 2: move the GARG-AML scoring core across verbatim - #2
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Six modules moved from the research repository with their function bodies
unchanged: _blocks, _ordering, measures, scores, preprocess, features.
Verified by 56 golden-fixture comparisons and 158 old-vs-new comparisons across
22 graph shapes in both directions, including the degenerate ones (empty graph,
isolated nodes, clique, perfect smurfing pattern).
Original function names are retained deliberately — renaming in the same step as
moving would destroy the property that makes the move auditable. PEP 8 names,
type hints and NumPy docstrings follow in Phase 3.
Three ruff rules (SIM108, RUF005, PD002) are suppressed for src/garg_aml/*.py in
a block marked TEMPORARY; all three ask for body rewrites that belong to Phase 3,
where the fixtures are green and can vouch for each change. _blocks.py keeps a
separate, permanent SIM108 exemption: its else-branches hold the frozen
degenerate-case constants.