Skip to content

⚡ Optimize VLC RunWait implementation to eliminate arbitrary Sleep delay #102

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ven0m0 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

⚡ Optimize VLC RunWait implementation to eliminate arbitrary Sleep delay #102

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
06c3f61
Perf: Remove hardcoded sleep delay in PlayBootVideo
Ven0m0 May 4, 2026
ddec760
Perf: Remove hardcoded sleep delay in PlayBootVideo
Ven0m0 May 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions .github/workflows/ahk-lint-format-compile.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,10 +19,20 @@ jobs:
- uses: actions/checkout@v6

- name: Install AutoHotkey v1.1 (Portable)
run: choco install autohotkey.portable --version=1.1.36.01 -y
run: |
for ($i = 0; $i -lt 3; $i++) {
choco install autohotkey.portable --version=1.1.36.01 -y
if ($LASTEXITCODE -eq 0) { break }
Start-Sleep -Seconds 5
}
shell: pwsh
- name: Install AutoHotkey v2
run: choco install autohotkey -y
run: |
for ($i = 0; $i -lt 3; $i++) {
choco install autohotkey -y
if ($LASTEXITCODE -eq 0) { break }
Start-Sleep -Seconds 5
}
shell: pwsh
- name: Verify Installations
run: |
Expand Down
3 changes: 1 addition & 2 deletions Other/playnite-all.ahk
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,7 @@ PlayBootVideo() {
vlcPath := MustGetExe("vlc.exe", ["C:\Program Files\VideoLAN\VLC\vlc.exe"])
bootVideo := A_ScriptDir . "\BootVideo.mp4"
vlcArgs := '--fullscreen --video-on-top --play-and-exit --no-video-title -Idummy "' . bootVideo . '"'
RunWait('cmd.exe /c START "" "' . vlcPath . '" ' . vlcArgs, , "hide")
DllCall("kernel32.dll\Sleep", "UInt", 3000)
RunWait('"' . vlcPath . '" ' . vlcArgs, , "hide")
Copy link
Copy Markdown

@gemini-code-assist gemini-code-assist Bot May 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

high

The use of the "hide" parameter in RunWait will likely cause the VLC video window itself to be hidden, which prevents the boot video from being seen.

In the previous implementation, "hide" was applied to the cmd.exe process, while VLC was launched via the START command (which defaults to showing the window). When calling vlc.exe directly, the "hide" option should be removed to ensure the video output is visible. VLC's -Idummy flag already handles hiding the player's control interface.

    RunWait('"' . vlcPath . '" ' . vlcArgs)

}
LaunchPlaynite() {
playniteExe := MustGetExe(
Expand Down
Loading