Fix QuantizedGraph<float> source compatibility for v0.3.6 - #106
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
PR #105 made
QuantizedGrapha non-template class, so existing C++ callers usingQuantizedGraph<float>stopped compiling. Restore the float specialization while retaining the compiled implementation and C++17 deduction guides for callers that omit<float>.Update the builder, Python bindings, examples, and documentation to use the restored API. Add regression coverage for explicit/default template arguments, deduction, and move semantics. Bump the CMake and Python package versions to 0.3.6.
Validation
RABITQ_ENABLE_NATIVE_OPTIMIZATION=OFF: all 144 C++ tests passed; C++ samples built. Used the locally available GoogleTest 1.11.0.QuantizedGraph<float>::search.Compatibility
Restores the
QuantizedGraph<float>C++ source API and preserves C++17 variable declarations using deduction. The implementation remains float-only. No index-format, Python API, or production dependency changes.