Skip to content

Code-review - #104

Merged
gouyt13 merged 1 commit into
mainfrom
review/code-review
Sep 15, 2026
Merged

gouyt13 merged 1 commit into
mainfrom
review/code-review

Conversation

@gouyt13

@gouyt13 gouyt13 commented Sep 15, 2026

Copy link
Copy Markdown
Member

Summary

  • Make packed-factor access and aligned storage ownership safe while preserving contiguous QG rows and persisted formats.
  • Fix IVF inner-product cluster routing and pruning inputs.
  • Validate index state, search parameters, allocation sizes, and file contents; preserve existing indexes on failed loads.
  • Correct SIMD feature detection, unaligned accesses, and worker cleanup.
  • Fix clang-tidy include ordering.

Validation

  • ASan/UBSan: 133/133 passed with native optimization off and leak detection disabled.
  • NoPython: 132/132 passed against the rebuilt extension.
  • Clang 15 analysis: 20/20 library/binding translation units passed.
  • Formatting, Python lint, ShellCheck, whitespace checks, and strict documentation build passed.

- Make packed-data access and aligned ownership safe.
- Preserve contiguous QG rows with a single vector<T>.
- Change IVF inner-product routing and pruning.
- Validate index state, search arguments, allocations, and file input.
- Preserve existing indexes when loading fails.
- Correct SIMD feature detection and unaligned accesses.
- Improve worker cleanup and local thread-count handling.
@gouyt13
gouyt13 merged commit 025e65d into main Sep 15, 2026
20 checks passed
@gouyt13
gouyt13 deleted the review/code-review branch September 15, 2026 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant