feat(symqg): use PiPNN for initialization by default - #103
Merged
Merged
Conversation
- Encapsulate PiPNN initialization in QGBuilder with one refinement pass - Add init selection to C++ and Python APIs, retaining random initialization - Update documentation, examples,
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem and change
SymphonyQG now uses native PiPNN initialization followed by one refinement iteration by default, replacing random initialization with three iterations. The intermediate graph and temporary storage remain internal to QGBuilder.
Validation
97 C++ tests and 43 SymphonyQG Python tests passed, along with formatting and focused clang-tidy checks. Performance was not remeasured after the numerical fix.
Compatibility
Adds an optional initialization argument to the C++ and Python build APIs, defaulting to PiPNN. Explicit random initialization remains available with three iterations.
Existing call signatures remain usable, but default construction behavior changes. Index formats and dependencies are unchanged.