Fix cache UI actions without UI context - #8508
Open
plafosse wants to merge 1 commit into
Open
Conversation
zznop
approved these changes
Sep 2, 2026
zznop
left a comment
Member
There was a problem hiding this comment.
These changes look good to me. Looks like all cache action paths are addressed and it prevents dereferencing a null context pointer. When the context is NULL I assume that it's possible work can outlive the UI. But, I think we permit that elsewhere.
bdash
approved these changes
Sep 2, 2026
bdash
left a comment
Contributor
There was a problem hiding this comment.
This seems fine as a defensive fix, but we should file a follow-up issue about the fact that a context menu item invoked an action with a null UIContext.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix cache image-loading actions invoked without an active UI context, preventing null dereferences during background execution. Also applies the same protection to dyld shared-cache actions.
Repro:
First select the unloaded green address then run:
This should fix issue: https://github.com/Vector35/binaryninja/issues/1898