Skip to content

[PPCVLE] Fix I16L-form immediate decoding: use 5-bit mask for ui0_4 #7553

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
plafosse merged 1 commit into from
Nov 1, 2025
Merged

[PPCVLE] Fix I16L-form immediate decoding: use 5-bit mask for ui0_4 #7553

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions arch/powerpc/decode/vle32.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -383,9 +383,10 @@ static void FillOperands32Vle(Instruction* instruction, uint32_t word32, uint64_
case PPC_ID_VLE_E_AND2IS:
case PPC_ID_VLE_E_OR2I:
case PPC_ID_VLE_E_OR2IS:
case PPC_ID_VLE_E_LIS:
{
uint32_t ui5_15 = word32 & 0x7ff;
uint32_t ui0_4 = (word32 >> 16) & 0xf;
uint32_t ui0_4 = (word32 >> 16) & 0x1f;
uint32_t ui = (ui0_4 << 11) | ui5_15;

PushRA(instruction, word32);
Expand Down Expand Up @@ -622,11 +623,6 @@ static void FillOperands32Vle(Instruction* instruction, uint32_t word32, uint64_
break;
}

case PPC_ID_VLE_E_LIS:
PushRD(instruction, word32);
PushUIMMValue(instruction, ui_split16);
break;

case PPC_ID_VLE_E_MCRF:
PushCRFD(instruction, word32);
PushCRFS(instruction, word32);
Expand Down