[SharedCache] Fix issue #7247 - #7477
Merged
Merged
Conversation
See Vector35#7247 (comment) for details.
Author
|
I've tested this and it does fix it, however I'm not sure if there are other implications to the changes. Maybe there is a reason the code wasn't written this way in the first place that causes issues further on down the line? Or maybe it was just a simple mistake. |
Member
|
I think this is OK and the correct thing to do, I cannot recall any reason as to why you would want to add the on-disk directory when opening a project file. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See #7247 (comment) for details.